Update HexToDec.py #135
Open
Update HexToDec.py #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code has a few issues: The __getDecDigit() function is unnecessarily defined as a private function. Since it is not a method of a class, it can simply be defined as a regular function. The __getDecDigit() function can be simplified by using the index() method of a list to find the index of the given digit. The hexToDec() function is not returning the decimal number, it is only printing it. It should be modified to return the value instead. The loop in the hexToDec() function is iterating over the length of the hex number in reverse order. This is unnecessary and can be simplified to a regular forward loop.
AvinashYerra
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has a few issues:
The __getDecDigit() function is unnecessarily defined as a private function. Since it is not a method of a class, it can simply be defined as a regular function. The __getDecDigit() function can be simplified by using the index() method of a list to find the index of the given digit. The hexToDec() function is not returning the decimal number, it is only printing it. It should be modified to return the value instead. The loop in the hexToDec() function is iterating over the length of the hex number in reverse order. This is unnecessary and can be simplified to a regular forward loop.